This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Disallow inline display maths#5939
Merged
uhoreg merged 1 commit intomatrix-org:developfrom Apr 29, 2021
Merged
Conversation
uhoreg
reviewed
Apr 28, 2021
uhoreg
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes element-hq/element-web#17095 by changing the default regex for display maths to only parse display maths when it starts and ends on a new line.
I believe this is acceptable since display maths will be rendered using the full page width anyway.
The default behavior in
config.jsoncan now be reproduced as follows: