This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Merged
Conversation
Member
|
I haven't looked at the code, but the screenshots look great - thank you! A designer will be able to review it a bit better than I. Something to consider is abusive invite reasons: we might need to hide these behind disclosures or blurs or something. |
turt2live
approved these changes
Mar 22, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Code seems generally fine - thanks for taking a look!
robintown
force-pushed
the
show-invite-reasons
branch
from
6b3c374 to
9da2b27
Compare
Displays the reason for invitation in the invitation dialog, requiring a click to reveal the message. Signed-off-by: Robin Townsend <robin@robin.town>
robintown
force-pushed
the
show-invite-reasons
branch
from
9da2b27 to
8f721ec
Compare
robintown
force-pushed
the
show-invite-reasons
branch
from
8f721ec to
2477258
Compare
Member
Author
|
Ummm why are the tests failing? It looks unrelated to these changes |
Collaborator
|
Seems to have been an intermittent failure. |
Collaborator
|
Oh no, I forgot about the Design review... 😓 |
Collaborator
|
I guess I'll revert it and open a new PR. 😭 |
Collaborator
|
I'll try to rustle up some Design feedback before the RC, and perhaps we can tweak as needed from there. |
Collaborator
|
I created element-hq/element-web#16869 to track any design feedback. |
This was referenced Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displays the reason for invitation in the invitation dialog, requiring a click to reveal the message. I based it on this mockup, which I assume still needs a design review.
Closes element-hq/element-web#14832.