MSC4108 support OIDC QR code login by t3chguy · Pull Request #12370 · matrix-org/matrix-react-sdk

t3chguy · 2024-03-25T18:20:49Z

Requires matrix-org/matrix-js-sdk#4134
Closes https://github.com/element-hq/wat-internal/issues/52

Known differences from the Figma designs:

Some typography differences due to Heading font size mismatches between Figma & Compound
Learn more button on error state missing as we have nowhere to route it to

Screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

The implementation was incorrect

… hughns/oidc-qr-prototyping

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… hughns/oidc-qr-prototyping # Conflicts: # src/Lifecycle.ts # src/components/views/auth/LoginWithQRFlow.tsx # src/components/views/settings/devices/LoginWithQRSection.tsx

… hughns/oidc-qr-prototyping

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/oidc-qr-prototyping Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> # Conflicts: # res/css/views/auth/_LoginWithQR.pcss # src/components/views/auth/LoginWithQR-types.ts # src/components/views/auth/LoginWithQR.tsx # src/components/views/auth/LoginWithQRFlow.tsx # src/components/views/dialogs/UserSettingsDialog.tsx # src/components/views/settings/devices/LoginWithQRSection.tsx # src/components/views/settings/tabs/user/SessionManagerTab.tsx # test/components/views/settings/devices/__snapshots__/LoginWithQRFlow-test.tsx.snap

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

…3218cb4dfff97d Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/oidc-qr-prototyping # Conflicts: # src/components/views/dialogs/UserSettingsDialog.tsx # test/components/views/settings/devices/__snapshots__/LoginWithQRFlow-test.tsx.snap # test/test-utils/client.ts # test/test-utils/test-utils.ts

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/oidc-qr-prototyping

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

src/components/structures/UserMenu.tsx

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

…o t3chguy/oidc-qr-prototyping

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/oidc-qr-prototyping

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/oidc-qr-prototyping # Conflicts: # src/components/views/auth/LoginWithQR.tsx # src/components/views/auth/LoginWithQRFlow.tsx # test/components/views/settings/devices/LoginWithQR-test.tsx # test/components/views/settings/devices/LoginWithQRFlow-test.tsx

hughns and others added 16 commits March 14, 2024 12:29

WIP prototype of MSC4108

d625b61

Async import rendezvous bits as they include the rust crypto wasm blob

40ae685

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Iterate PR

096f2f3

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Switch to generating/parsing MSC4108 QR codes via Rust Crypto

74f7621

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Wait until secure channel is confirmed before doing OIDC registration

94dd62b

The implementation was incorrect

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

74000bb

… hughns/oidc-qr-prototyping

Wire up rust-crypto qr secrets import/export

8f6174a

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

7055165

… hughns/oidc-qr-prototyping # Conflicts: # src/Lifecycle.ts # src/components/views/auth/LoginWithQRFlow.tsx # src/components/views/settings/devices/LoginWithQRSection.tsx

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

274999c

… hughns/oidc-qr-prototyping

Shuttle secrets via credentials and avoid calling doSetLoggedIn twice

fbfb0f4

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Restore key backup after importing QR secrets

62d3e7a

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Remove unused method

02154ab

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Delint

b4cd325

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

i18n

6054a71

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Ensure rust crypto wasm is loaded async

2b8ffa3

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Remove changes which rely on major oidc-client-ts upstream changes

887a2b9

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 25, 2024

github-actions bot deployed to Netlify March 25, 2024 18:23 View deployment

Prettier

99b5213

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify March 25, 2024 18:31 View deployment

github-actions bot deployed to EndToEndTests March 25, 2024 18:57 View deployment

Remove login qr flows

fda2898

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify March 26, 2024 08:59 View deployment

Simplify

a7ba73b

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify March 26, 2024 09:09 View deployment

github-actions bot deployed to EndToEndTests March 26, 2024 09:28 View deployment

Restore legacy QR code login

f808b49

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify March 26, 2024 09:57 View deployment

Iterate

0874348

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify March 26, 2024 10:45 View deployment

t3chguy added 17 commits May 1, 2024 10:05

delint

a213f2c

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Cull more early code

9b6fcac

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Tidy

6998dea

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Fix error handling

4105dfa

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' into t3chguy/oidc-qr-prototyping

fd0cf4b

Bump @matrix-org/matrix-sdk-crypto-wasm to 90b63b84df65c19161f94049d8…

d97ee26

…3218cb4dfff97d Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

i18n

88efbc7

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Tweak copy

57cc27d

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' into t3chguy/oidc-qr-prototyping

d7b5035

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

f0c6272

… t3chguy/oidc-qr-prototyping

Discard changes to yarn.lock

8129f50

i18n

c5d61a2

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Iterate

a66d1bf

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Iterate

80c31e2

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' into t3chguy/oidc-qr-prototyping

d9b3c4d

hughns reviewed May 28, 2024

View reviewed changes

src/components/structures/UserMenu.tsx Show resolved Hide resolved

Skip checkQrLoginSupport if OIDC labs flag is not enabled

34223b2

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

MidhunSureshR approved these changes May 29, 2024

View reviewed changes

hughns and others added 8 commits May 31, 2024 09:21

Use RendezvousError.code as failure reason during approveLogin()

9f2afe0

Lint

fe0d014

Update copy

07e2c07

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge remote-tracking branch 'origin/t3chguy/oidc-qr-prototyping' int…

3619e27

…o t3chguy/oidc-qr-prototyping

Update snapshot

8eb5d1b

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

4113ec0

… t3chguy/oidc-qr-prototyping

Iterate

14275a5

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Iterate

5fa8598

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy mentioned this pull request Jun 5, 2024

Use LegacyRendezvousFailureReason over RendezvousFailureReason #12578

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MSC4108 support OIDC QR code login#12370

MSC4108 support OIDC QR code login#12370
t3chguy merged 120 commits intodevelopfrom
t3chguy/oidc-qr-prototyping

t3chguy commented Mar 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

t3chguy commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

t3chguy commented Mar 25, 2024 •

edited

Loading