Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Only respect X-Needs-Percy in the Merge Queue#10520

Merged
t3chguy merged 8 commits intodevelopfrom
t3chguy/merge_queue2
Apr 6, 2023
Merged

Only respect X-Needs-Percy in the Merge Queue#10520
t3chguy merged 8 commits intodevelopfrom
t3chguy/merge_queue2

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Apr 5, 2023 •
edited by github-actions bot
Loading

Requires #10515

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 5, 2023
@t3chguy t3chguy requested review from a team as code owners April 5, 2023 12:48
@t3chguy t3chguy requested review from germain-gg and justjanne and removed request for a team April 5, 2023 12:48
@t3chguy t3chguy self-assigned this Apr 5, 2023
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 5, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@luixxiul
Copy link
Copy Markdown
Contributor

luixxiul commented Apr 5, 2023

I am wondering if this change would make it impossible to take snapshots of the draft PR. Thanks.

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Apr 5, 2023

Yes it will. But that is less important than losing the ability to get daily percy runs on the develop branch.

@luixxiul
Copy link
Copy Markdown
Contributor

luixxiul commented Apr 5, 2023

I understood. So after this PR we will get daily snapshots and a snapshot of the merged commit of the PR labelled with X-Needs-Percy. Am I right?

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Apr 5, 2023 •
edited
Loading

Yes, there will still be an ability to "test" Percy before merging using X-Needs-Percy + X-Blocked + Merge Queue, but it'll be up to your reviewer

@luixxiul
Copy link
Copy Markdown
Contributor

luixxiul commented Apr 5, 2023

I understood. Thank you!

Base automatically changed from t3chguy/merge_queue to develop April 6, 2023 14:03
@t3chguy t3chguy enabled auto-merge April 6, 2023 14:14
@t3chguy t3chguy added this pull request to the merge queue Apr 6, 2023
Merged via the queue into develop with commit 9cecac0 Apr 6, 2023
@t3chguy t3chguy deleted the t3chguy/merge_queue2 branch April 6, 2023 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-team

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@andybalaam andybalaam andybalaam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@t3chguy t3chguy

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t3chguy @luixxiul @andybalaam