Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add a test for ReplyChain#10294

Merged
SimonBrandner merged 4 commits intomatrix-org:developfrom
luixxiul:test-replychain
Mar 7, 2023
Merged

Add a test for ReplyChain#10294
SimonBrandner merged 4 commits intomatrix-org:developfrom
luixxiul:test-replychain

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented Mar 6, 2023 •
edited
Loading

Closes element-hq/element-web#24684

This PR intends to add a test for ReplyChain as a follow-up to #8972.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul added 2 commits March 7, 2023 01:11
@luixxiul
Invite the bot and have it send a message
b77e952 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Show a reply chain, check CSS values, set Percy tests
71f6657 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Mar 6, 2023
@luixxiul
Remove a whitespace character
9118cd4 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review March 6, 2023 16:53
@luixxiul luixxiul requested a review from a team as a code owner March 6, 2023 16:53
@SimonBrandner SimonBrandner merged commit 7c2bb96 into matrix-org:develop Mar 7, 2023
@luixxiul
Copy link
Copy Markdown
Contributor Author

luixxiul commented Mar 7, 2023

Thanks for the quick review.

@luixxiul luixxiul deleted the test-replychain branch March 7, 2023 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a cypress test with percy snapshot for ReplyChain

2 participants

@luixxiul @SimonBrandner