Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix predecessor tests broken#10123

Merged
germain-gg merged 1 commit intodevelopfrom
gsouquet/fix-tets
Feb 9, 2023
Merged

Fix predecessor tests broken#10123
germain-gg merged 1 commit intodevelopfrom
gsouquet/fix-tets

Conversation

@germain-gg
Copy link
Copy Markdown
Contributor

@germain-gg germain-gg commented Feb 9, 2023

Sending an event now clears notifications, the test was broken because we create mock event with the sender being the logged in user

See matrix-org/matrix-js-sdk#3139

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 9, 2023
@germain-gg germain-gg requested a review from a team as a code owner February 9, 2023 11:53
@germain-gg germain-gg enabled auto-merge (squash) February 9, 2023 11:53
Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@germain-gg germain-gg merged commit 8fe5714 into develop Feb 9, 2023
@germain-gg germain-gg deleted the gsouquet/fix-tets branch February 9, 2023 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants