This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Migrate SpotlightDialog for dynamic room predecessors#10076
Merged
weeman1337 merged 1 commit intodevelopfrom Feb 3, 2023
Merged
Migrate SpotlightDialog for dynamic room predecessors#10076weeman1337 merged 1 commit intodevelopfrom
weeman1337 merged 1 commit intodevelopfrom
Conversation
weeman1337
added
the
T-Task
andybalaam
approved these changes
Feb 3, 2023
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks great. I added a video proving it works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide rooms that are predecessors according to MSC3946 on the Spotlight dialog.
Tests only assert that the correct parameter is passed to the mocked MatrixClient.
Other tests should cover that an actual client considers the flag.
Towards matrix-org/matrix-spec-proposals#3946
closes element-hq/element-web#24426
PSF-1895
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.