Include tests in the source distribution#15
Merged
reivilibre merged 1 commit intomainfrom Jan 20, 2022
Merged
Conversation
anoadragon453
approved these changes
Jan 20, 2022
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is not the same thing as marking them as packages (that get installed into site-packages) and in my test this didn't include them in the wheels either; this is purely for the source distribution (which packagers sometimes appreciate so they can check that their packages do the trick),
This is in line with what we do for Synapse and is also in line with what a lot of packages do, both in Python and out.