Improve compliance with MSC3266

[AndrewFerr]

This fixes some non-compliance with MSC 3266, and exports the payload type.

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• Sign-off given on the changes (see CONTRIBUTING.md).

[t3chguy]

Please improve the PR title given it will be used in the changelog verbatim

[t3chguy]

Looks sane otherwise

[AndrewFerr]

Please improve the PR title given it will be used in the changelog verbatim

Done -- let me know if the title still needs changing.

I am also willing to add an integration test for this.

[t3chguy]

Yeah looks like CI won't let it in without testing

[AndrewFerr]

Good thing CI is strict, because this PR requires a Synapse change too: element-hq/synapse#17078

[t3chguy]

So we'll likely need fallback code then
for older Synapse support

[AndrewFerr]

So we'll likely need fallback code then for older Synapse support

The Synapse PR has a fallback: it responds to both the old & new endpoint used by getRoomSummary.

Then again, getRoomSummary could also have a fallback: if it gets a 404 response for the new endpoint, it can retry at the old endpoint. I'll add that now.

[AndrewFerr]

Hm, even with the integration test, the code analysis check is failing. What needs to be added to fix that?

Other than that, bd09442 adds the fallback, so once the check is fixed, this should PR be ready.

[t3chguy]

Hm, even with the integration test, the code analysis check is failing

It says you reached 33.3% coverage, out of the required 80%.

Things marked red are untested.

[t3chguy]

Looks sane

[AndrewFerr]

Alright, code coverage for new code is now at 100%, so this should be done.

[AndrewFerr]

Do I need to rebase this PR branch before it can be merged?