Add join_rule field to /publicRooms response#3673
Merged
germain-gg merged 1 commit intomatrix-org:developfrom Aug 23, 2023
Merged
Conversation
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
github-actions
bot
added
T-Enhancement
Z-Community-PR
3 tasks
germain-gg
approved these changes
Aug 23, 2023
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
That looks good, thank you for your contribution!
charlynguyen
deleted the
charlynguyen/add-join-rule-field-to-public-rooms-response
branch
3 tasks
This was referenced Aug 29, 2023
This was referenced Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We @nordeck are currently implementing the knock rooms behind the feature flag
feature_ask_to_join(introduced in matrix-org/matrix-react-sdk#11182).This pull request adds the
join_rulefield to/publicRoomsresponse (MSC2403).Epic: element-hq/element-web#18655
BlocksAllow setting knock room visibility matrix-react-sdk#11464Checklist
Here's what your changelog entry will look like:
✨ Features
join_rulefield to /publicRooms response (#3673). Contributed by @charlynguyen.