Element-R: Pull out an interface from VerificationBase#3414
Merged
Conversation
This was referenced May 26, 2023
richvdh
force-pushed
the
rav/element-r/14_verifier_interface
branch
from
78fb7ba to
53b487f
Compare
richvdh
changed the base branch from
develop
to
rav/element-r/14.0_new_verifier_base_methods
richvdh
force-pushed
the
rav/element-r/14_verifier_interface
branch
2 times, most recently
from
6bae4a6 to
4d2a062
Compare
Base automatically changed from
rav/element-r/14.0_new_verifier_base_methods
to
develop
June 6, 2023 11:28
richvdh
force-pushed
the
rav/element-r/14_verifier_interface
branch
from
dee577f to
a44b968
Compare
richvdh
force-pushed
the
rav/element-r/14_verifier_interface
branch
from
a44b968 to
31f6a60
Compare
richvdh
force-pushed
the
rav/element-r/14_verifier_interface
branch
from
31f6a60 to
43611fd
Compare
richvdh
changed the title
Verifier interfaceVerificationBase
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 22, 2024
* Introduce a new `Crypto.Verifier` interface, and deprecate direct access to `VerificationBase`, `SAS` and `ReciprocateQRCode` ([\matrix-org#3414](matrix-org#3414)). * Add `rust-crypto#isCrossSigningReady` implementation ([\matrix-org#3462](matrix-org#3462)). Contributed by @florianduros. * OIDC: Validate `m.authentication` configuration ([\matrix-org#3419](matrix-org#3419)). Contributed by @kerryarchibald. * ElementR: Add `CryptoApi.getCrossSigningStatus` ([\matrix-org#3452](matrix-org#3452)). Contributed by @florianduros. * Extend stats summary with call device and user count based on room state ([\matrix-org#3424](matrix-org#3424)). Contributed by @toger5. * Update MSC3912 implementation to use `with_rel_type` instead of `with_relations` ([\matrix-org#3420](matrix-org#3420)). * Export thread-related types from SDK ([\matrix-org#3447](matrix-org#3447)). Contributed by @stas-demydiuk. * Use correct /v3 prefix for /refresh ([\matrix-org#3016](matrix-org#3016)). Contributed by @davidisaaclee. * Fix thread list being ordered based on all updates ([\matrix-org#3458](matrix-org#3458)). Fixes element-hq/element-web#25522. * Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald. * use cli.canSupport to determine intentional mentions support ([\matrix-org#3445](matrix-org#3445)). Fixes element-hq/element-web#25497. Contributed by @kerryarchibald. * Make sliding sync linearize processing of sync requests ([\matrix-org#3442](matrix-org#3442)). * Fix edge cases around 2nd order relations and threads ([\matrix-org#3437](matrix-org#3437)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abstract base class
VerificationBase(along with its two concrete subclassesSASandReciprocateQRCode) implement the logic for performing a device or user verification once a specific verification method has been agreed between the two parties.We want to reimplement this in Rust, so as a first step, pull out an interface from the current Javascript implementation, which in future we can implement with a rust-backed implementation - and deprecate direct access to the old classes..
Notes: Introduce a new
Crypto.Verifierinterface, and deprecate direct access toVerificationBase,SASandReciprocateQRCodePart of https://github.com/vector-im/crypto-internal/issues/95.
Here's what your changelog entry will look like:
🦖 Deprecations
Crypto.Verifierinterface, and deprecate direct access toVerificationBase,SASandReciprocateQRCode(#3414).