Merged
Conversation
turt2live
reviewed
Jan 6, 2023
Member
turt2live
left a comment
There was a problem hiding this comment.
Thanks! Looks like we indeed don't use this dependency.
Just one comment about the lockfile before we can merge this.
'qs' appears to be unused since 34c5598 (PR matrix-org#2719). Signed-off-by: Clark Fischer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'qs' (package, source) appears to be unused since 34c5598 (PR #2719), and can be safely removed.
It's worth noting that 'qs' has the deepest dependency graph of all (non-development) dependencies.
No other dependencies have more than one level of nesting.
#244 is relevant here (maybe?), though this doesn't go particularly far. A full dev install still weighs 372M on my machine, though this reduces a production install from 9.3M to 8.6M.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.