Fix sync init when thread unread notif is not supported#2739
Merged
germain-gg merged 10 commits intodevelopfrom Oct 7, 2022
Merged
Fix sync init when thread unread notif is not supported#2739germain-gg merged 10 commits intodevelopfrom
germain-gg merged 10 commits intodevelopfrom
Conversation
t3chguy
requested changes
Oct 7, 2022
| return new Filter(this.client.credentials.userId); | ||
| const filter = new Filter(this.client.credentials.userId); | ||
| if (this.client.canSupport.get(Feature.ThreadUnreadNotifications)) { | ||
| filter.setUnreadThreadNotifications(true); |
Member
There was a problem hiding this comment.
setUnreadThreadNotifications only uses the stable non-prefixed version but this.client.canSupport.get(Feature.ThreadUnreadNotifications) will return true if unstable is supported.
Contributor
Author
There was a problem hiding this comment.
Good catch! I've changed the code to use UnstableValue.
I believe I had not done that in the first place after seeing how setProp works... it essentially treats . in property names as a nested level
Member
There was a problem hiding this comment.
Maybe we should update setProp to take a variadic list of keys rather than a string to avoid this problem
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
reviewed
Oct 7, 2022
t3chguy
approved these changes
Oct 7, 2022
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Looks sane to me! Any chance of an extra test around /sync actually including this filter?
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Oct 29, 2022
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801. * Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680. * Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760. * Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk. * Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)). * Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)). * Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)). * Add custom notification handling for MSC3401 call events ([\matrix-org#2720](matrix-org#2720)). * Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)). * Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)). * Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839. * Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206. * Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505. * Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)). * Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)). * Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke. * Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435. * Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#23435
Creates a solution to detect features available on a given homeserver.
Developers can now document what matrix version will support a feature as well as the unstable prefixes. This code path is then accessible synchronously
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes