Implementation of MSC3882 login token request#2687
Merged
Conversation
Merged
12 tasks
weeman1337
reviewed
Sep 22, 2022
SimonBrandner
approved these changes
Sep 22, 2022
weeman1337
approved these changes
Sep 22, 2022
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
LGTM now 👍
Could still use some tests for code coverage 😉
Member
Author
|
@weeman1337 tests now added too. 🤞 |
weeman1337
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the added functionality is just passing through an HTTP request I don't think unit tests are needed for this.
Checklist
Here's what your changelog entry will look like:
✨ Features