Skip to content

Don't crash with undefined room in processBeaconEvents() #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonBrandner merged 2 commits into from
Jul 11, 2022
Merged

Don't crash with undefined room in processBeaconEvents() #2500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3596c8
Don't crash with undefined room in `processBeaconEvents()`
SimonBrandner Jul 7, 2022
62e7601
Make `room` optional
SimonBrandner Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8947,9 +8947,9 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa
room: Room,
events?: MatrixEvent[],
): void {
if (!events?.length) {
return;
}
if (!events?.length) return;
if (!room) return;

room.currentState.processBeaconEvents(events, this);
}

Expand Down