Implement MSC3531: Hiding messages during moderation#2041
Conversation
turt2live
changed the title
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
As a first pass there's mostly spec-related workflow concerns on this, but the change overall seems sensible. I've also left a review on the MSC itself which might ultimately impact the review of the actual visibility change code.
|
Apologies, I realized too late that I was missing a big part of the patch to handle redactions. Added. |
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
overall this is looking fine - just a few more nitpicks, mostly around the project structure
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
almost there :)
There's also MSC feedback which will need addressing ftr. Those aspects are not covered in code review.
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
one more step, and then we're there :)
|
... after you fix merge conflicts and the build :D (try merging develop - should fix both, hopefully) |
|
(please don't force push onto reviewed branches - it invalidates review, thus making it required for re-review. In this case, the changes appear fine) |
3 participants
Matrix-js-sdk-level support for hiding messages.
This is my first patch in matrix-js-sdk, please accept my apologies for anything I have done wrong.
MSC: matrix-org/matrix-spec-proposals#3531
Signed-off-by: David Teller davidt@element.io
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.