Conversation
gileluard
requested review from
a team and
stefanceriu
and removed request for
a team
ismailgulek
approved these changes
Oct 4, 2022
Contributor
ismailgulek
left a comment
ismailgulek
left a comment
There was a problem hiding this comment.
I had a look to understand element-hq/element-ios#6798 better and lgtm!
Contributor
Author
|
@ismailgulek Yeah ... I didn't think this PR lacks of context.... |
stefanceriu
approved these changes
Oct 4, 2022
Member
stefanceriu
left a comment
stefanceriu
left a comment
There was a problem hiding this comment.
I'm happy if Ismail is happy but looks good to me too 👍 😄
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1596 +/- ##
==========================================
Coverage ? 13.48%
==========================================
Files ? 542
Lines ? 86707
Branches ? 36842
==========================================
Hits ? 11689
Misses ? 74576
Partials ? 442
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gileluard
deleted the
gil/6797-Display_push_toggle_for_sessions_with_m.local_notification_settings.device-id
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for #6797
As per MSC3890 we'll need to catch the new
m.local_notification_settings.<device-id>event in the account data to know if the session support local notification and if it's silenced.