Skip to content

Add test to make sure /messages behaves as expected for non-existent room_id's #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kegsay merged 4 commits into from
May 11, 2022
Merged

Add test to make sure /messages behaves as expected for non-existent room_id's #369

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0237a5e
Add test to make sure /messages behaves as expected for non-existent …
MadLittleMods May 10, 2022
0115c72
Explain why 403
MadLittleMods May 10, 2022
eff19fc
Remove dendrite skip
MadLittleMods May 10, 2022
55b2974
Merge branch 'main' into madlittlemods/12678-403-when-/messages-with-…
kegsay May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/csapi/room_messages_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,24 @@ func TestSendAndFetchMessage(t *testing.T) {
})
}

// With a non-existent room_id, GET /rooms/:room_id/messages returns 403
// forbidden ("You aren't a member of the room").
Copy link
Copy Markdown
Collaborator Author

@MadLittleMods MadLittleMods May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in the spec,

403 | You aren’t a member of the room.

-- https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages

func TestFetchMessagesFromNonExistentRoom(t *testing.T) {
deployment := Deploy(t, b.BlueprintAlice)
defer deployment.Destroy(t)

alice := deployment.Client(t, "hs1", "@alice:hs1")
roomID := "!does-not-exist:hs1"

// then request messages from the room
queryParams := url.Values{}
queryParams.Set("dir", "b")
res := alice.DoFunc(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "messages"}, client.WithQueries(queryParams))
must.MatchResponse(t, res, match.HTTPResponse{
StatusCode: http.StatusForbidden,
})
}

// sytest: PUT /rooms/:room_id/send/:event_type/:txn_id sends a message
// sytest: PUT /rooms/:room_id/send/:event_type/:txn_id deduplicates the same txn id
func TestSendMessageWithTxn(t *testing.T) {
Expand Down