fix: return m.change_password capability based on login_with_password config#388
fix: return m.change_password capability based on login_with_password config#388chbgdn wants to merge 1 commit intomatrix-construct:mainfrom
Conversation
chbgdn
force-pushed
the
sso-pw-change
branch
2 times, most recently
from
bbdf55e to
ce4b1ec
Compare
|
Thank you for this but I don't think we can merge it until #314 is closed as SSO users must be able to set a password right now to use UIA-requiring features such as session removal. |
|
@jevolk I actually have a working branch that implements SSO UIA, which would allow SSO users to use UIA-requiring features. The code isn't perfect, but it's tested and working. Would you like me to open it as a draft PR so you can see the approach? |
Wow ABSOLUTELY! 🙏 I will be happy to pick up where you left off. This is a high priority issue going into the next dev cycle. |
I've opened this as a draft PR (#389). Just to set expectations - this is more of a prototype/proof of concept. I'm not sure I have the skills/experience to polish it to merge-ready state, but hopefully the implementation can be useful as a reference or starting point. Feel free to take ideas/code from it if helpful, or I can try to improve it with your guidance. |
2 participants
Sets the
m.change_passwordcapability based on thelogin_with_passwordconfig option. By default, the capability returnsenabled: true, but now it will correctly returnenabled: falsewhen password login is disabled (e.g., SSO-only setups).This allows clients to correctly determine whether password changes are supported.