Skip to content

fix: return m.change_password capability based on login_with_password config#388

Open
chbgdn wants to merge 1 commit intomatrix-construct:mainfrom
chbgdn:sso-pw-change
Open

fix: return m.change_password capability based on login_with_password config#388
chbgdn wants to merge 1 commit intomatrix-construct:mainfrom
chbgdn:sso-pw-change

Conversation

@chbgdn
Copy link
Copy Markdown

@chbgdn chbgdn commented Mar 22, 2026

Sets the m.change_password capability based on the login_with_password config option. By default, the capability returns enabled: true, but now it will correctly return enabled: false when password login is disabled (e.g., SSO-only setups).

This allows clients to correctly determine whether password changes are supported.

@chbgdn chbgdn force-pushed the sso-pw-change branch 2 times, most recently from bbdf55e to ce4b1ec Compare March 22, 2026 21:38
@jevolk
Copy link
Copy Markdown
Member

jevolk commented Mar 22, 2026

Thank you for this but I don't think we can merge it until #314 is closed as SSO users must be able to set a password right now to use UIA-requiring features such as session removal.

@jevolk jevolk added the feature New feature or functionality that didn't exist. label Mar 22, 2026
@chbgdn
Copy link
Copy Markdown
Author

chbgdn commented Mar 22, 2026

@jevolk I actually have a working branch that implements SSO UIA, which would allow SSO users to use UIA-requiring features. The code isn't perfect, but it's tested and working.

Would you like me to open it as a draft PR so you can see the approach?

@jevolk
Copy link
Copy Markdown
Member

jevolk commented Mar 22, 2026

@jevolk I actually have a working branch that implements SSO UIA, which would allow SSO users to use UIA-requiring features. The code isn't perfect, but it's tested and working.

Would you like me to open it as a draft PR so you can see the approach?

Wow ABSOLUTELY! 🙏 I will be happy to pick up where you left off. This is a high priority issue going into the next dev cycle.

@chbgdn
Copy link
Copy Markdown
Author

chbgdn commented Mar 22, 2026

Wow ABSOLUTELY! 🙏 I will be happy to pick up where you left off. This is a high priority issue going into the next dev cycle.

I've opened this as a draft PR (#389).

Just to set expectations - this is more of a prototype/proof of concept. I'm not sure I have the skills/experience to polish it to merge-ready state, but hopefully the implementation can be useful as a reference or starting point.

Feel free to take ideas/code from it if helpful, or I can try to improve it with your guidance.

@jevolk jevolk self-assigned this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or functionality that didn't exist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants