fix(sync): stop prior long-poll on reconnection#386
Open
chocycat wants to merge 1 commit intomatrix-construct:mainfrom
Open
fix(sync): stop prior long-poll on reconnection#386chocycat wants to merge 1 commit intomatrix-construct:mainfrom
chocycat wants to merge 1 commit intomatrix-construct:mainfrom
Conversation
Member
|
Thank you so much for finding this issue. This is actually a really delicate matter given some of the specific quirks discovered in the SDK and sliding sync. I'm going to need to review this thoroughly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client disconnects (browser refresh or network drop) during a sliding sync long-poll, the server continues to hold the connection mutex until the full timeout expires. Any new request from the same client on the same
conn_idblocks on acquiring this lock, causing the user to wait for the previous request's timeout before the sync resumes.This adds a
Notifyto each connection entry, so when a new request arrives for the same(user, device, conn_id), it notifies the previous handler, which then exits the long-poll loop and releases the mutex. The new request proceeds immediately.Reproduction
Tested on Tuwunel v1.5.1 with a live server.