Make server bot / user name configurable.#119
Draft
obioma wants to merge 1 commit intomatrix-construct:mainfrom
Draft
Make server bot / user name configurable.#119obioma wants to merge 1 commit intomatrix-construct:mainfrom
obioma wants to merge 1 commit intomatrix-construct:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the proposal for fixing #117 bei making the server bot/user name configurable after finding out that the original proposal was not well analyzed (in respect to existing databases).
Basically now it can be decided if to use either 'conduit' or 'tuwunel' as name. Why only two? not really necessary, but to keep it in line with having a well defined one (the old 'conduit') only a second choice is added. Also, the validation helps to ensure that not '@' prefixes are used or an empty string, which would raise a panic due to usage of the function
parse_with_server_namein Ruma.I hope it is acceptable.