Skip to content

Conversation

@tzi
Copy link
Contributor

@tzi tzi commented Nov 3, 2025

Description:

The new Matomo loader has a lot of greatness:

  • No HTTP request
  • transparent background
  • Cleaner in screen with high pixel density

In this PR I migrated all easy ones in the same time. The easy ones are:

  • loaded in HTML, not in CSS
  • in the core repository, not in the plugins

I already migrated 3 of them without any complications, so… Why not all of them 😄

User visitor map

before after
Screenshot 2025-11-05 at 17 16 56 Screenshot 2025-11-05 at 17 16 38

Marketplace example

before after
Screenshot 2025-11-05 at 15 13 45 Screenshot 2025-11-05 at 15 14 24

Review

@tzi tzi added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Nov 3, 2025
@michalkleiner michalkleiner marked this pull request as draft November 5, 2025 01:34
@tzi tzi added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Nov 5, 2025
@tzi tzi marked this pull request as ready for review November 5, 2025 14:02
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @tzi, thanks!

In a follow up, if there's time and energy, we can also update the twig include to have the <span class="loadingPiwik"> wrapper in it, making it a single line where it's used with the default loading text. The include can also take extra params such as whether the style should be display:none, display:visible or missing (probably not relevant as when it's missing, it should be visible). We can also override the loading message or hide it if needed. We can do that in a follow up PR.

@michalkleiner michalkleiner merged commit a076560 into 5.x-dev Nov 5, 2025
88 of 91 checks passed
@michalkleiner michalkleiner deleted the upgrade-loader branch November 5, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review

Development

Successfully merging this pull request may close these issues.

3 participants