Conform spelling of ID to Swift API design guidelines#464
Open
idrougge wants to merge 2 commits intomatomo-org:developfrom
Open
Conform spelling of ID to Swift API design guidelines#464idrougge wants to merge 2 commits intomatomo-org:developfrom
ID to Swift API design guidelines#464idrougge wants to merge 2 commits intomatomo-org:developfrom
Conversation
brototyp
reviewed
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.swift.org/documentation/api-design-guidelines/#general-conventions states that
This includes the initialism "ID"; one might note that it is uniformly spelt with either all uppercase or all lowercase in all Swift standard library and Apple APIs.
This PR would align Matomo, which currently uses a mix of
IDandId, with those guidelines. Fallbacks with fixits have been provided for all public symbols.