Skip to content

Conform spelling of ID to Swift API design guidelines#464

Open
idrougge wants to merge 2 commits intomatomo-org:developfrom
idrougge:id
Open

Conform spelling of ID to Swift API design guidelines#464
idrougge wants to merge 2 commits intomatomo-org:developfrom
idrougge:id

Conversation

@idrougge
Copy link
Contributor

@idrougge idrougge commented Mar 4, 2025

https://www.swift.org/documentation/api-design-guidelines/#general-conventions states that

Acronyms and initialisms that commonly appear as all upper case in American English should be uniformly up- or down-cased according to case conventions:

var utf8Bytes: [UTF8.CodeUnit]
var isRepresentableAsASCII = true
var userSMTPServer: SecureSMTPServer 

This includes the initialism "ID"; one might note that it is uniformly spelt with either all uppercase or all lowercase in all Swift standard library and Apple APIs.

This PR would align Matomo, which currently uses a mix of ID and Id, with those guidelines. Fallbacks with fixits have been provided for all public symbols.

Copy link
Collaborator

@brototyp brototyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @idrougge, thanks for the PR.
Looks good to me and I am happy to merge it though. Just one small question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants