Scaling error on load with rotation

[bpatrik]

In case of rotating the image, after that fitting and finally reinitalising the guillotine with the same transformation pramteres, the library zooms in.

The sollution for the problem can be to switch the rotate and the zoom order at the _init function:
if ((angle = parseInt(o.angle))) { this._rotate(angle); } if ((scale = parseFloat(o.scale))) { this._zoom(scale); }

[matiasgali]

@bpatrik it's possible that the issue lays with the dimensions of your particular image and the order in which you transform it.

This example loads Guillotine, rotates and fits the image and reloads the plugin with the new data. Everything seems to work as expected, I can't reproduce the issue.

Please update that fiddle or provide a new working example that shows the behavior you describe to allow debugging it.

[bpatrik]

@matiasgagliano sorry, the bug report was a bit short.
It occurs, if I put a landscape image to a portrait div(or the other way) and rotate the image with 90 and fit it.

The problem can be the following:
I have a div with dimension: 200x100
An image 150x200.
After Rotating and fitting the image, dimension of the image will be 200x150 and scale will be 1.0
Saving the transformation Object and re-initializing the library with it, the following happens:
The lib first processes the scale, which is 1.0. It sees that the divis 200x100 and the image is 150x200, which doesn't fill the div, so the scale will be set to 1.333. After that, it processes the rotation, the scale remains 1.33, which is invalid, since it should be 1.0.

As I tested, this could be a solution, but I haven't read the whole source code:

Moving the rotate processing before the scale processing here:
https://github.com/matiasgagliano/guillotine/blob/master/js/jquery.guillotine.js#L192

I hope it helps, let me know, if more details is needed.

[matiasgali]

Now I get what you are saying. That particular order was used to fix issue #17.

To avoid both issues the init method should scale and rotate without having any method that tries to fix smaller dimensions (fit) in the middle. It should check dimensions after the process is done.

It's not a hard problem to solve but requires major refactoring to do it right. I'll begin working on it in my spare time but it might take a while, I'm currently loaded with work.

Thanks for reporting it.

[bpatrik]

Ok, thank you for your help.

[haqqi]

I also get this bug. Any idea when you will solve this? Or is there any other solution?