Conversation
…grid group When moving panels from floating groups back to newly created empty groups using addGroup() + moveTo(), the component content was disappearing due to improper component lifecycle management during the move operation. The issue occurred because when moveGroupOrPanel was called with skipSetActive=true, the component wouldn't get properly rendered in empty destination groups. - Fix moveGroupOrPanel to force component rendering when moving to empty groups - Add comprehensive test in floating groups section verifying the fix works - Ensure component lifecycle is preserved during floating->grid moves Fixes #996 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3ca12d0:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GitHub issue #996 where component content disappears when moving panels from floating groups back to newly created empty groups using the
addGroup()+moveTo()pattern.Problem
When users moved panels from floating groups to new grid groups using:
The component content would disappear, making panels appear empty. This only affected moves to newly created empty groups - moves to existing groups worked fine.
Root Cause
The issue was in the
moveGroupOrPanelmethod. When moving panels to empty groups,skipSetActive: trueprevented the component from being properly rendered in the destination group's contentContainer.Solution
File:
src/dockview/dockviewComponent.tsAdded logic to detect when the destination group is empty and force component rendering by setting
skipSetActive: false:Testing
Added comprehensive test in the "floating groups" section of
dockviewComponent.spec.tsthat:Verification
Impact
This fix ensures that panels moved from floating groups to new grid groups maintain their component content visibility, resolving the user-reported issue where components would appear empty after the move.
Closes #996
🤖 Generated with Claude Code