Patch CSSStyleDeclaration to handle units of 'ex' (and others). Resolves issue #233 #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
Author
Since it is a jsdom (or rather CSSStyleDeclaration) problem, not a mathjax-node problem, I'm not sure it needs a test here. If you want some tests for the various jsdom issues that we have patched, then I suppose that could be done, but I think it is not necessary. |
Member
Author
|
PS, the tests passed when I ran them by hand, but I had an older copy of SRE. When I update that, the tests fail. :-( |
Contributor
Sounds good to me. |
Contributor
|
The tests now pass thanks to @zorkow's fixes to SRE. Yay to travis for catching these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the copy of CSSStyleDeclaration to handle units of
exand a number of other missing units. The change really should only be in one line (thelengthRegEx), but since that is down inside a closure, I can't get my hands on it, so I have to replace the entirevalueType()routine with a duplicate that uses my own copy oflengthRegEx. Resolves issue #233.