Make test for node hierarchy more robust. #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. |
Member
Author
|
@pkra, I'm happy to merge. Does that mean a new release of mathjax-node? |
dpvc
added a commit
that referenced
this pull request
Feb 22, 2016
Make test for node hierarchy more robust.
Contributor
Sure. I had set up a milestone for "what's next" but this seems urgent, right? |
Member
Author
|
It would be a good idea to get this out, I think. |
Contributor
👍 from me. I will finish the PR to master and make a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test was dependent on the current directory. My tests were done from the mathjax-node directory itself, but when it is installed with
npm install mathjax-node, rather than getting a copy of mathjax-node from github and runningnpm installin it, you get anode_modulesdirectory, and so the current directory is not the same as what I was using, and the test for node version 4 failed, and it tried to use the node-5 hierarchy. This leads to the error reported in issues #172 and #179.This patch uses a test that doesn't rely on the current directory.