-
-
Notifications
You must be signed in to change notification settings - Fork 471
Open
Labels
readyReady for implementationReady for implementationrestricted: maintainersOnly maintainers can resolve this issueOnly maintainers can resolve this issuetype: bugwork: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory
Milestone
Description
The Record Page has a few places where we make API requests and don't adequately handle server errors:
-
$: record = new RecordStore({ table, recordId });
The
RecordStoreconstructor callsRecordStore.fetchwhich fetches the record data. If this fails, then the page loads, giving the user the impression that all fields in the record are blank. -
$: tableStructure = new TableStructure({ id: table.id, abstractTypesMap: $currentDbAbstractTypes.data, });
The
TableStructureconstructor instantiates other stores which fetch data within their constructors. -
{#await getJoinableTablesResult(table.id)} <RecordPageLoadingSpinner /> {:then joinableTablesResult} <Widgets {joinableTablesResult} {recordId} recordSummary={$summary} /> {/await}The
getJoinableTablesResultfunction might throw an error. We should handle this. We should also eliminate code duplication with thegetJoinableTablesResultfunction insrc/stores/tables.ts
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
readyReady for implementationReady for implementationrestricted: maintainersOnly maintainers can resolve this issueOnly maintainers can resolve this issuetype: bugwork: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory