Inconsistent behavior of adsorption workflow #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adsorption workflow seems to produce inconsistent adsorption sites for the molecule, although using structure matching shows that these sites are equivalent
This leads to issues when
_check_poscaris called, since the adsorbed molecule site(s) cannot be found. Tests pass in numpy >= 2, can't migrate up to numpy > 2 in CI without isolating certain packages (e.g., matgl)Temporarily remove the POSCAR check just for those jobs which work on the surface + adsorption
Also remove some unused features and fix bugs in adsorption workflow related to removing sites