feat(layout-grid): parameterize layout grid #795
Conversation
|
@yeelan0319 FYI that commit message needs to be formatted as |
|
Thanks for pointing that out. I will look for some examples, I know it must be documented somewhere. |
yeelan0319
force-pushed
the
feat/layout-improvement
branch
from
794b508 to
0dd2629
Compare
|
I changed the commit message. PTAL |
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 65 65
Lines 2767 2767
Branches 318 318
=======================================
Hits 2765 2765
Misses 2 2Continue to review full report at Codecov.
|
| --mdc-layout-grid-margin: 40px; | ||
| --mdc-layout-grid-gutter: 16px; | ||
| --mdc-layout-grid-margin-desktop: 40px; | ||
| --mdc-layout-grid-gutter-tablet: 16px; |
There was a problem hiding this comment.
nit: perhaps we should also show --mdc-layout-grid-gutter-phone being used here?
BREAKING CHANGE: the css custom properties for customize margins and gutters are exposed in format of `mdc-layout-grid-margin-#{$size}`, where valid sizes are `desktop`, `tablet` and `phone`. The old name `mdc-layout-grid-margin` and `mdc-layout-grid-gutter` is no longer available in the new version. Sass variables change from single numeric value to Sass map to accomendate margins and gutters for different screens as well. Visually, the default value of margins and gutters change from 16px to 24px on desktop, while remain the same on tablet and mobile.
yeelan0319
force-pushed
the
feat/layout-improvement
branch
from
0dd2629 to
d0f8999
Compare
BREAKING CHANGE in css custom properties and sass variables.