[Button] Fix click sound for checkable button #4967
Conversation
|
|
||
| @Override | ||
| public boolean performClick() { | ||
| if (isEnabled() && materialButtonHelper.isToggleCheckedStateOnClick()) { |
There was a problem hiding this comment.
@pubiqq thanks for the PR - can you explain why the isEnabled() check is removed? is it because perfomClick() should already never be called if the button is disabled? if so, I agree that the user can't click a disabled button, but it's possible that this method is called programmatically on a disabled button, so maybe we should keep it and do isEnabled() && isCheckable() && materialButtonHelper.isToggleCheckedStateOnClick()?
There was a problem hiding this comment.
Components such as android.widget.Button and android.widget.CheckBox perform click actions when the performClick method is called, even if they're disabled. I see no reason why the MaterialButton should be any different.
Also, the original implementation is incorrect because clicking on the disabled button works inconsistently; it doesn't invoke the toggle() method, but still performs click actions.
2 participants
Also fixes #4966.