Add a version comment to the emoji preval-ed file so it is regenerated#28700
Merged
Gargron merged 1 commit intomastodon:mainfrom Jan 12, 2024
Merged
Add a version comment to the emoji preval-ed file so it is regenerated#28700Gargron merged 1 commit intomastodon:mainfrom
Gargron merged 1 commit intomastodon:mainfrom
Conversation
This is a follow up on mastodon#28404 In the PR above, the emoji data has been changed. But `emojii_compressed.js` is using `babel-preval`, so it is executed when processed with Babel, and then Babel will cache the resulting code. This causes the frontend to no longer load after deploying the change, because Babel did not detect any change in `emoji_compressed.js` (the real file), so it re-used it from its cache, but the actuel content that needs to be consumed by Webpack and appear in the final bundle is different (it contains the new emoji data). Adding this comment will change the checksum for `emoji_compressed.js`, which should invalidate Babel's cache and force the file to be executed again on the next build.
renchap
force-pushed
the
regenerate-emoji-preval
branch
from
ecad14e to
01bb76a
Compare
Member
Author
Gargron
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #28404
In the PR above, the emoji data has been changed. But
emojii_compressed.jsis usingbabel-preval, so it is executed when processed with Babel, and then Babel will cache the resulting code.This causes the frontend to no longer load after deploying the change, because Babel did not detect any change in
emoji_compressed.js(the real file), so it re-used it from its cache, but the actuel content that needs to be consumed by Webpack and appear in the final bundle is different (it contains the new emoji data).Adding this comment will change the checksum for
emoji_compressed.js, which should invalidate Babel's cache and force the file to be executed again on the next build.Note: I have not tested that it works