fix(process): Close check handle #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neovim documentation doesn't make it very clear, but checks are handles and need to be closed. Neovim will close them after time specified in `src/nvim/event/loop.c:loop_close()`, but at the cost of exit code signifying something went wrong. Fixes mason-org#1994
2 tasks
williamboman
approved these changes
Jul 28, 2025
Member
williamboman
left a comment
williamboman
left a comment
There was a problem hiding this comment.
Thanks, good catch! And very well written bug report 👍. I added a close call to the check handle in InstallHandle.lua to make sure it gets cleaned up as well
rahuliyer95
pushed a commit
to rahuliyer95/mason.nvim
that referenced
this pull request
Nov 17, 2025
rahuliyer95
pushed a commit
to rahuliyer95/mason.nvim
that referenced
this pull request
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim documentation doesn't make it very clear, but checks are handles and need to be closed.
Neovim will close them after time specified in
src/nvim/event/loop.c:loop_close(), but at the cost of exit code signifying something went wrong.I saw the fix in Neovim codebase.
There's one more
new_checkcall in this plugin, inInstallHandle.lua. I think it might need closing as well, but I see it also calls__clear_event_handlerswhich I am not familiar with.Fixes #1994