Skip to content

Conversation

@XeroOl
Copy link
Contributor

@XeroOl XeroOl commented Aug 2, 2025

Describe your changes

The fennel-ls rockspec on luarocks now declares that it doesn't support windows,
so that information doesn't need to be duplicated in mason-repository.

Issue ticket number and link

#11047

https://luarocks.org/manifests/xerool/fennel-ls-0.2.1-2.rockspec

The fennel-ls rockspec on luarocks now declares that it doesn't
support windows, so that information doesn't need to be duplicated
in mason-repository.

mason-org#11047
https://luarocks.org/manifests/xerool/fennel-ls-0.2.1-2.rockspec
@williambotman williambotman requested a review from a team August 2, 2025 03:35
@Conarius
Copy link
Contributor

Conarius commented Aug 2, 2025

Huh, weird. It correctly says it doesn't support windows. Maybe supported_platforms should suffice in this case.

@chrisgrieser
Copy link
Member

Maybe changes at luarocks need a bit before they are applied due to caching?

@williamboman
Copy link
Member

williamboman commented Aug 2, 2025

Ah, I completely oversaw the CI behavior when a platform is not supported, for some reason I assumed this specific error would be handled, which it's not (Mason just passes the Luarocks error forward).

Let's just keep the ci_skip for now, other options would require extending Luarocks support in mason.nvim to handle such cases.

edit: The supported_platforms approach would be possible with mason-org/mason.nvim#2002.

@chrisgrieser chrisgrieser added the blocked:mason-change-required a change at one the other mason repos is required label Aug 2, 2025
@XeroOl XeroOl closed this Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked:mason-change-required a change at one the other mason repos is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants