Skip to content

fix: polyfill usage #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maslianok merged 1 commit into from
Feb 16, 2021
Merged

fix: polyfill usage #137

maslianok merged 1 commit into from
Feb 16, 2021

Conversation

@khmm12
Copy link
Contributor

@khmm12 khmm12 commented Feb 9, 2021

ResizeObserver and window.ResizeObserver are different constants from rollup-plugin-inject parser point of view.

It should either ResizeObserver in the code or window.ResizeObserver in rollup-plugin-inject replacements.

@lucascaro
Copy link

lucascaro commented Feb 10, 2021

I can confirm the polyfills seem to not be working at the moment:

error

@JanStevens JanStevens mentioned this pull request Feb 15, 2021
Closed
@maslianok maslianok merged commit e9ac85f into maslianok:master Feb 16, 2021
@maslianok
Copy link
Owner

maslianok commented Feb 16, 2021

Thank you! 👍

@khmm12 khmm12 deleted the fix/polyfill-usage branch February 17, 2021 11:54
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khmm12 @lucascaro @maslianok