Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves keyboard accessibility across the Museeks music player application. It centralizes focus ring styling into the global CSS, removes scattered outline: none declarations from individual components, and wraps the settings navigation in a Radix UI NavigationMenu for proper ARIA semantics. It also includes routine dependency version bumps.
Changes:
- Adds global
:focus-visibleand:focus:not(:focus-visible)styles togeneral.css, replacing per-componentoutline: nonedeclarations across multiple components. - Wraps
SettingsNav/SettingsNavLinkwith Radix UINavigationMenuprimitives for proper list-based navigation semantics and accessibility. - Bumps several dependency versions (
@stylexjs/*,@tanstack/*,lightningcss,uuid).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/styles/general.css |
Replaces old button/input outline resets with global :focus-visible and :focus:not(:focus-visible) rules |
src/elements/SettingsNav.tsx |
Wraps navigation with Radix NavigationMenu for a11y; adds list reset styles |
src/components/VolumeControl.tsx |
Removes per-component outline: 'none' on :active for slider thumb |
src/components/TrackRow.tsx |
Removes outline: 'none' from track row styles |
src/components/TrackList.tsx |
Removes outline: 'none' from track list container |
src/components/SideNavLink.tsx |
Removes outline: 'none' from active side nav link |
src/components/Setting.tsx |
Removes outline: 'none' on :focus from select and input styles |
src-tauri/Cargo.toml |
Bumps uuid from 1.21.0 to 1.22.0 |
src-tauri/Cargo.lock |
Lock file update for uuid and transitive dependencies |
package.json |
Bumps @stylexjs/*, @tanstack/*, and lightningcss versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- Other