Version parsing for upgrade decision #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I slightly changed the if block. It is comparing full version names with different hashes for same version in the current state of the script. For example: New Ver: 1.2.2.4282-a97b03fad Cur Ver: 1.22.2.4282-6000 I cut the suffix from the version, so only the part before the first dash is taken into the account in the IF. In the example above it would parse both new and current versions to "1.22.2.4282". I'm only using the shorter versions to decide if upgrading is necessary, so you can still see the full version in logs.
|
Another option is to get the right version number, e.g., by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I slightly changed the IF block.
It is comparing full version names with different hashes for same version in the current state of the script.
For example:
I cut the suffix from the version, so only the part before the first dash is taken into the account in the IF. In the example above it would parse both new and current versions to
1.22.2.4282I'm only using the shorter versions to decide if upgrading is necessary, so you can still see the full version in logs.