Merged
Conversation
Owner
martincostello
commented
Jun 18, 2025
- Only generate on Windows.
- Rename file.
- Only generate on Windows. - Rename file.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SBOM generation process by restricting it to run only on Windows and renaming the generated SBOM file.
- Only generates SBOM on Windows runners
- Renames the generated artifact and output file for clarity
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:87
- The new artifact name 'xunit-logging.spdx.json' may be misleading if the file content remains an SBOM. Consider using a name that more clearly reflects its purpose.
artifact-name: xunit-logging.spdx.json
.github/workflows/build.yml:88
- Ensure that the new output file name accurately reflects its content. If the file is an SBOM, a name such as 'sbom.spdx.json' might be more intuitive.
output-file: ./artifacts/xunit-logging.spdx.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 16 16
Lines 284 284
Branches 37 37
=======================================
Hits 280 280
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Nov 11, 2025
This was referenced Dec 1, 2025
This was referenced Dec 9, 2025
Open
This was referenced Dec 21, 2025
This was referenced Jan 5, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.