Allow <Title> to be non configurable

[markyao6275]

This addresses #8776

Testing:

Added storybook entry

[markyao6275]

@fzaninotto @adguernier I believe this is ready for review again. Thanks!

[adguernier]

Reviewed. Thanks for your work @markyao6275 👍

[markyao6275]

Thanks for the comments @adguernier! Should be ready for another review :)

[adguernier]

Aside from the last two comments, LGTM. Thanks for your work 💪

[djhi]

Thanks! I think the default preferenceKey in Title should be the same as in PageTitleConfigurable and you should check if preferenceKey is strictly equal to false.

[markyao6275]

@djhi you mean I should check if preferenceKey strictly equal to undefined right?

Anyway I tried to address your feedback in the most recent commit so please let me know if that's what you had in mind.

[djhi]

@djhi you mean I should check if preferenceKey strictly equal to undefined right?

I mean that to have it work like it did before, we should have a default preferenceKey set and users have to explicitly disable it by setting it to false. Hence, you should check if it is strictly equal to false to render the non configurable version. This is coherent with other part of react-admin.

[markyao6275]

@djhi just acted on your feedback

For

I mean that to have it work like it did before, we should have a default preferenceKey

I just passed through the preferenceKey from <Title /> to <PageTitleConfigurable /> so that I don't have to specify the default ${pathname}.title in more than one place.

Let me know if there's anything else you'd like me to change.

[markyao6275]

@djhi friendly bump here

[markyao6275]

@djhi addressed, thanks!

[markyao6275]

@djhi friendly bump here

[slax57]

Other than that, it works fine, thanks! 🙂

[markyao6275]

@slax57 addressed your comments, thanks!