Fix ReferenceManyField executes filter reset filter too often#10371
Merged
Fix ReferenceManyField executes filter reset filter too often#10371
Conversation
slax57
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We used an alternative to
setStatecalledsafeSetStatethat disabled some React linter warnings. This silenced a problem of effect running too often inuseListanduseReferecneManyFieldController.The removal of
safeSetStatein #10341 revealed the problem, which is now reported by a linter warning (e.g. , https://github.com/marmelab/react-admin/pull/10370/files#diff-66e51c85b7ef7a61bc686a09a730355d6cc188a86670eb5d710d0d41d74ad5fe)Solution
Add the required dependencies