Add a *SELECT ALL* button in the <BulkActionsToolbar>#10367
Merged
fzaninotto merged 147 commits intonextfrom Jan 3, 2025
Merged
Add a *SELECT ALL* button in the <BulkActionsToolbar>#10367fzaninotto merged 147 commits intonextfrom
<BulkActionsToolbar>#10367fzaninotto merged 147 commits intonextfrom
Conversation
12 tasks
fzaninotto
reviewed
Nov 20, 2024
| name: getResourceLabel(resource, 2), | ||
| }); | ||
|
|
||
| const { data: allData } = useGetList<RecordType>( |
Member
There was a problem hiding this comment.
You'd better use the data provider directly in the callback, or using react-query's useMutation. useGetList is really designed for queries triggered on mount.
fzaninotto
approved these changes
Jan 3, 2025
<BulkActionsToolbar><BulkActionsToolbar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Datagrid already allows to select all the records of a given page. But sometimes users want to select all records across all pages, e.g. to delete all the records of a resource. Also, when not in a datagrid (e.g. contact list in CRM demo), there is no way to select all records.
Solution
In the bulk actions toolbar, add a “select all” link close to the number of selected items.
Already started in #9043, but needs a different approach
To do - V1
<List>with a<Datagrid>-> local story<ReferenceManyField>-> local story<ReferenceArrayField>-> local story<InfiniteList>-> local storyra-coretests to transfor rendered component to storiesInformations
The
limitprop is not usefull for theuseListhook because this hook received all the data directly so we don't need to call it.So, the
<RerefenceArrayField>doesn't need thelimitprop.The "SELECT ALL" button will alway display when the API use a partial pagination.
To do - V2
SelectAllButtonformetaandlimitAdditional Checks
masterfor a bugfix, ornextfor a feature