[Storybook] Re-enable storysource addon#10363
Merged
fzaninotto merged 6 commits intomasterfrom Nov 27, 2024
Merged
Conversation
slax57
changed the title
erwanMarmelab
approved these changes
Nov 27, 2024
slax57
force-pushed
the
addon-storysource
branch
from
397537d to
ae131f3
Compare
fzaninotto
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storybook storysource addon (allowing to display the source code for a story in the 'Code' panel) was broken since we updated to Storybook v8.
It would be nice to re-enable it to allow viewers of our storybook to also view the matching source code.
Solution
I actually managed to track down a bug in Storybook, preventing this addon to work in the first place.
This PR re-enables the plugin, and is to be merged when the issue is fixed in a new storybook release.
Blocked: wait until storybookjs/storybook#29669 is merged and released
=> EDIT: No news from storybook maintainers, so this PR uses a local patch instead.
How To Test
Run storybook, and check the source code of each story is present in the 'Code' panel.
https://react-admin-storybook-i85occt9g-marmelab.vercel.app/?path=/story/ra-core-form-filterliveform--basic