[SimpleList] deprecate linkType, and implement rowClick as for the DataGrid#10349
[SimpleList] deprecate linkType, and implement rowClick as for the DataGrid#10349quentin-decre wants to merge 96 commits intomarmelab:nextfrom
Conversation
270c3b6 to
ede21f4
Compare
djhi
left a comment
There was a problem hiding this comment.
Thanks! This is a new feature though. Can you target the next branch?
This reverts commit 58edc9c.
…dy exist when createLabel is provided
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
…oning its children
…houldUnregister in React.StrictMode
ede21f4 to
6ca2f0d
Compare
J'ai rebase sur next et changé la target, mais je ne comprends pas pourquoi il met autant de diff. Ce sont bien des commits qui sont déjà sur next non ? |
Malheuresement non. Comme vous pouvez le voir dans le CHANGELOG de la branche Pourriez-vous recréer une nouvelle branche (basée sur |
|
We just merged master on next, can you rebase? |
|
Closed in favor of #10385 |
Problem
The linkType for SimpleList provides less functionality than the rowClick for DataGrid. And also the inconsistency makes it harder to use.
Solution
Implement rowClick prop as it works for Datagrid.
Keep the linkType prop working as previously, but show it as deprecated. If both are set, linkType takes precedence (because it will be simpler to remove from the code later that way).
How To Test
Similar to data grid
Additional Checks
masterfor a bugfix, ornextfor a feature