Skip to content

Fix <PrevNextButtons> index when using paginated results#10144

Merged
slax57 merged 2 commits intomasterfrom
fix-PrevNextButtons-pagination-index
Aug 14, 2024
Merged

Fix <PrevNextButtons> index when using paginated results#10144
slax57 merged 2 commits intomasterfrom
fix-PrevNextButtons-pagination-index

Conversation

@slax57
Copy link
Contributor

@slax57 slax57 commented Aug 14, 2024

Problem

Fix #10136

Solution

Fix the index computation in case the data comes from the query cache and page > 1

How To Test

The fix can be tested in Storybook or in the E-commerce Demo

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date -> no need

Also, please make sure to read the contributing guidelines.

@slax57 slax57 added this to the 5.1.2 milestone Aug 14, 2024
@slax57 slax57 merged commit 22dae61 into master Aug 14, 2024
@slax57 slax57 deleted the fix-PrevNextButtons-pagination-index branch August 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Development

Successfully merging this pull request may close these issues.

Incorrect index display in PrevNextButtons component on pagination navigation

1 participant