Support multiple emails and phone numbers per contact#80
Merged
erwanMarmelab merged 20 commits intomainfrom Jan 14, 2025
Merged
Support multiple emails and phone numbers per contact#80erwanMarmelab merged 20 commits intomainfrom
erwanMarmelab merged 20 commits intomainfrom
Conversation
slax57
changed the title
slax57
commented
Jan 13, 2025
djhi
suggested changes
Jan 13, 2025
src/contacts/ContactAside.tsx
Outdated
Comment on lines
+55
to
+67
| <Box> | ||
| <EmailField source="email" />{' '} | ||
| <WithRecord | ||
| render={row => | ||
| row.type !== 'Other' && ( | ||
| <TextField | ||
| source="type" | ||
| color="textSecondary" | ||
| /> | ||
| ) | ||
| } | ||
| /> | ||
| </Box> |
Contributor
There was a problem hiding this comment.
Use flexbox instead of a space? This ensure better compatibility with custom themes.
src/contacts/ContactAside.tsx
Outdated
Comment on lines
+97
to
+109
| <Box> | ||
| <TextField source="number" />{' '} | ||
| <WithRecord | ||
| render={row => | ||
| row.type !== 'Other' && ( | ||
| <TextField | ||
| source="type" | ||
| color="textSecondary" | ||
| /> | ||
| ) | ||
| } | ||
| /> | ||
| )} | ||
| </Box> | ||
| </Stack> | ||
| )} | ||
| </Box> |
src/contacts/ContactInputs.tsx
Outdated
Comment on lines
+170
to
+174
| choices={[ | ||
| { id: 'Work' }, | ||
| { id: 'Home' }, | ||
| { id: 'Other' }, | ||
| ]} |
fzaninotto
approved these changes
Jan 13, 2025
erwanMarmelab
requested changes
Jan 14, 2025
| ## Additional Checks | ||
|
|
||
| - [ ] The **documentation** is up to date | ||
| - [ ] Tested with **fakerest** provider (see [related documentation](../doc/data-providers.md)) |
Contributor
There was a problem hiding this comment.
The link still open a "Not found" page
Collaborator
Author
There was a problem hiding this comment.
Nice catch! Should be fixed
slax57
commented
Jan 14, 2025
djhi
reviewed
Jan 14, 2025
| ); | ||
| }; | ||
|
|
||
| const personalInfoTypes = [{ id: 'Work' }, { id: 'Home' }, { id: 'Other' }]; |
Contributor
There was a problem hiding this comment.
FYI, all our choices inputs accept an array of strings since 5.1.0 (marmelab/react-admin#10038)
djhi
approved these changes
Jan 14, 2025
erwanMarmelab
approved these changes
Jan 14, 2025
Dballzall
pushed a commit
to Dballzall/media_crm
that referenced
this pull request
May 1, 2025
Support multiple emails and phone numbers per contact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Atomic CRM does not allow to have more than one email per contact. But it is frequent that contacts have multiple emails (work email, personal email, older emails, ...)
Also, it currently only allows to store 2 phone numbers.
Solution
Support having multiple emails and phone numbers per contact.
Todo
contacts_summaryview, so that we can do ilike search on itTests
Additional Checks
Also, please make sure to read the contributing guidelines.
Screenshots