feat(scanner): support comments between concise mode line attributes#6
Conversation
|
Warning Review limit reached
More reviews will be available in 7 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Port htmljs-parser's open-tag eol scan to the external scanner. In concise mode, `//` line and `/* */` block comments may now appear between comma-prefixed line attributes: the comment lines are scanned over (not emitted) and no longer terminate the open tag. A trailing comment with no following comma still ends the tag and is emitted as a normal comment (unchanged behavior). Both the concise_tag_epilogue lookahead (which sets tag_comma_continue) and the newline consumption inside the open-tag scan now skip whitespace and comment lines before the continuing comma, via a shared scan_line_attr_trivia helper. An unterminated block comment or a lone `/` ends the scan, matching the reference parser. Mirrors marko-js/htmljs-parser@4d28e16 (marko-js/htmljs-parser#203). Verified against htmljs-parser at that commit: the full fixture-comparison suite passes (374), including the new attr-comma-multiline-comments and attr-comma-multiline-comment- trailing fixtures, plus block/line/unterminated/CRLF edge cases.
8229de6 to
84c0a19
Compare
1 participant
Ports htmljs-parser's open-tag eol scan to the external scanner. In concise mode,
//line and/* */block comments may now appear between comma-prefixed line attributes — they are scanned over (not emitted) and no longer terminate the open tag. A trailing comment with no following comma still ends the tag and is emitted as a normal comment.This PR also adds a changeset for the change (see #7 for the changesets setup).
Mirrors marko-js/htmljs-parser@4d28e16 (marko-js/htmljs-parser#203).
Verified against htmljs-parser at that commit: the full fixture-comparison suite passes (374), including the new
attr-comma-multiline-commentsandattr-comma-multiline-comment-trailingfixtures, plus block/line/unterminated/CRLF edge cases.