-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove static properties from helpers #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/markedjs/markedjs/kmea584ch |
styfle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reads much better now, thanks 👍
Static properties used like this at the top-level are a common tree-shaking / dead code elimination deopt (because they affect other top-level statements) so ideally, this pattern should be avoided as much as possible.
This is the last PR from me today - I'd like to see how those play out first, but I have more changes planned.