Skip to content

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Jul 18, 2019

Marked version: master

Description

Allow baseUrl option to be a relative url.

Expectation

<p><img src="/favicon.ico" alt="alt text" title="relative"></p>

Result

<p><img src="/derp//favicon.ico" alt="alt text" title="relative"></p>

What was attempted

marked('![alt text](/favicon.ico "relative")', {baseUrl: "/derp/"});

Contributor

  • Test(s) exist to ensure functionality and minimize regression.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Jul 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://markedjs-git-fork-uzitech-baseurl-null.markedjs.now.sh

Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK from a regex perspective.

@UziTech UziTech merged commit aff0aa4 into markedjs:master Jul 19, 2019
@UziTech UziTech deleted the baseurl-null branch July 19, 2019 15:36
@UziTech UziTech mentioned this pull request Dec 4, 2019
12 tasks
This was referenced Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

baseUrl with relative prefix not working as expected.

4 participants