Add an option to not espace quotes.

[philipwalton]

I stumbled upon an issue that's giving me problems because marked is escaping double and single quotes in all situations and there's no option to change it.

https://github.com/chjj/marked/blob/master/lib/marked.js#L999-L1000

I'm no markdown expert, but I'm converting a project to node that previously used Ruby's rdiscount, which does not escape quotes. I do not see any reason (from an HTML perspective) to force escaping of quotes, so I think it makes sense to add an option to prevent this behavior.

If this is something you'd consider, I'd be happy to submit a pull request. Just let me know.

[jonschlinkert]

Agreed, this is a big problem for us with assemble. We use handlebars and marked.js together, and since marked.js alters templates, it's preventing us from adding marked.js as a default converter.

The problem is that by escaping quotes, marked converts {{foo 'include.md'}} to {{foo 'include.md'}}, which obviously is no longer a valid Handlebars template.

[philipwalton]

Yes, that's exactly the same problem I'm having. And it's with Handlebars no less.

Have you forked and fixed or simply chosen a different markdown converter?

[jonschlinkert]

helpers/example-pagination@59a08b7#commitcomment-4439647

[jonschlinkert]

assemble/assemble#343 (comment)

[jonschlinkert]

Have you forked and fixed or simply chosen a different markdown converter?

No, we just continue to use helpers for converting markdown, specifically so that we don't have to deal with the support issues related to this. However, before this continues to sound like like I'm complaining about marked, I really like this lib and use it quite extensively. We just don't have the time to support the issues related to including marked as a default converter.

However, we're refactoring assemble, and I want to have assemble convert markdown natively after that. So hopefully we can get this hammered out.

[jonschlinkert]

@chjj would you be open to someone helping out with this project? If so, I'd like to throw my hat in.

[mattly]

I just ran into this as well. Any progress?

[welldan97]

+1 same thing

[weekeight]

any progress? @chjj

[nfm]

I just had this same issue using Marked with React, which escapes everything by default.

I'm not 100% on the implications of this, but the React docs (http://facebook.github.io/react/docs/jsx-gotchas.html#html-entities) suggest using unicode characters to avoid escaping issues. Could Marked's escape() function (https://github.com/chjj/marked/blob/master/lib/marked.js#L1076) be modified to do replacements with unicode characters instead? For example, .replace(/"/g, '\u0022') instead of .replace(/"/g, '"')?

This seems to work ok for me on first inspection, but I'm not confident about the affects of this, and other things like browser support.

Anyone else care to weigh in?

[ethanmick]

Just ran into this. 👍

[adam-lynch]

Related: #529

[cri5ti]

The code in question seems to be here: https://github.com/chjj/marked/blob/master/lib/marked.js#L685

Shouldn't we have something like this?

if (this.options.sanitize)
    out += this.renderer.text(escape(this.smartypants(cap[0])));
else
    out += this.renderer.text(this.smartypants(cap[0]));